Nest: Performing msearch does not add "ignoreUnavailable"

[philbarresi]

When performing a multisearch like so:

            var results = await client.MultiSearchAsync(msd =>
            {
                 foreach(var entry in articles) {
                    msd = msd.Search<Article>(entry.Id, sd => sd
                        .Indices(indices)
                        .IgnoreUnavailable(); // other query stuff here
                 }
             }

The raw request, according to Fiddler, is:

POST http://10.211.55.3:9200/_msearch HTTP/1.1
Accept: application/json
Content-Type: application/json
Authorization: Basic
Host: 10.211.55.3:9200
Content-Length: 612

{"index":"index1,index2","type":"articleType"}
{myqueryhere}

I have verified independently that the search query works when pointed at an index or set of indices that exists, and so have omitted some details as this is a work related project. The only issue is that the first line of the request should be:

{"index":"index1,index2","type":"articleType", "ignoreUnavailable": true}

Which allows the multisearch to complete successfully.

I have looked at the repository and attempted to fix this issue myself, but I am woefully in over my head.

[bytenik]

+1

[gmarz]

@xueye It's being added as a query string parameter as opposed to being added to the request body, which is acceptable per the REST API spec.

Try checking the request URL in Fiddler to confirm.

[bytenik]

That's for search, but not multisearch.

[gmarz]

Sorry got ahead of myself there.

So that's pretty much the issue, since IMultiSearchRequest takes a collection a of ISearchRequest, each which add the option to the query string params.

I think adding the option to the request body instead of the query string params for ISearchRequest should do the trick. Looking into it now.

[bytenik]

It appears that line 292 of NestSerializer.cs should be:

ignoreUnavailable = operation.RequestParameters._ignore_unavailable

Of course that's just a theory because _ignore_unavailable is internal to elasticsearch.net and inaccessible to NEST.

[philbarresi]

I'm just confirming that the url is simply http://10.211.55.3:9200/_msearch, but it looks like you guys figured that out already.

[gmarz]

@xueye @bytenik Just pushed the above fix. Thanks for finding and pointing this out.