Stackoverflow exception when adding a query in a loop

[goalie7960]

I can consistently create a stackoverflow exception when I run this code. Maybe it's not the most efficient, but it did cause an issue in our code, especially when the maximum value of i is generated at runtime.

class Program
{
    static void Main(string[] args)
    {
        QueryContainer query = null;

        for (int i = 0; i < 10000; i++)
        {
            query |= Query<Thing>.Term(f => f.ID, i);
        }
    }
}

class Thing
{
    public int ID { get; set; }
}

[djnelson9715]

The better way to do this would be with a terms query

var ids = new List().

//Add you id to ids list

//Then run your query
Query.Terms(f=> f.ID, ids)

Hope this helps

On Mon, Oct 6, 2014 at 8:53 AM, Chris Heckathorne notifications@github.com
wrote:

I can consistently create a stackoverflow exception when I run this code.
Maybe it's not the most efficient, but it did cause an issue in our code,
especially when the maximum value of i is generated at runtime.

class Program
{
static void Main(string[] args)
{
QueryContainer query = null;

    for (int i = 0; i < 10000; i++)
    {
        query |= Query<Thing>.Term(f => f.ID, i);
    }
}

}

class Thing
{
public int ID { get; set; }
}

—
Reply to this email directly or view it on GitHub
#974.

Doug Nelson

[goalie7960]

That is fine for this example, thanks. But the issue still exists.

[Mpdreamz]

While I could not get it to stackoverflow on my machine the performance starts to degrade dramatically

These bitwise ops have been implemented mainly for DSL purposes and queries generally don't exceed more then a 100 individual queries pieces but what is very evident is that when it grows into the 1000s performance plummets.

1000 ops = 250ms
4000 ops = 4seconds

Which appears to a form of O(nX)

Whats going on is that this part of the code stacks a whole bunch of lazy concats to be evaluated:

https://github.com/elasticsearch/elasticsearch-net/blob/develop/src/Nest/DSL/Query/BoolQueryExtensions.cs#L35

which is then hit by this issue in the BCL:

https://connect.microsoft.com/VisualStudio/feedback/details/322004/poor-performance-of-multiple-chained-concat-commands

I'm working a fix now as well as refactoring the bitwise routines further.

[Mpdreamz]

This is now fixed in develop and doing 10000 iterations takes 150ms on my machine. In the process all the bits of code that deal with bitwise operators (&&, ||, !) are heavily refactored and simplified.

Thanks for reporting this one @goalie7960 !

[goalie7960]

Awesome! Thanks.