Skip to content

Update to .NET Core RC2 #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

phenixdotnet
Copy link

Hi.
please find a PR with all projects ported to .NET RC2.

  • All projects build only Nest.Litterateur has errors.
  • Some dependencies has been updated to allow targeting .NET Core RC2
  • Unit tests are ok on .NET Core but failed on Full .NET

@Mpdreamz
Copy link
Member

🎉 🎈 🍰 👍

Thanks for this PR @phenixdotnet, this is awesome.

@gmarz
Copy link
Contributor

gmarz commented May 26, 2016

@phenixdotnet indeed, this is awesome, thank you! Will pull this down in the coming days.

@phenixdotnet
Copy link
Author

@Mpdreamz , @gmarz : You're welcome :)
Most of the work was done with your version for .NET Core RC 1.

I didn't check why NEST.Litterateur doesn't build (the error is related to missing runtime but seem very strange).
Also unit tests fails when running on Full .NET framework and I didn't investigate why.

And thanks to you for this awesome lib :)

@russcam
Copy link
Contributor

russcam commented May 27, 2016

This is awesome @phenixdotnet , thanks for submitting 👍

I'll have a look at the build failures

@Strandedpirate
Copy link

Strandedpirate commented Jun 14, 2016

@phenixdotnet, @Mpdreamz , @gmarz
I got this Nest.Litteratuer to compile with this in project.json. It was just missing Microsoft.NETCore.App as a dependency.

"netcoreapp1.0": {
  "buildOptions": {
    "define": [
      "DOTNETCORE"
    ]
  },
  "dependencies": {
    "Microsoft.NETCore.App": {
      "type": "platform",
      "version": "1.0.0-rc2-3002702"
    },
    "System.IO.FileSystem": "4.0.1-rc2-24027",
    "Microsoft.CodeAnalysis.CSharp": "1.3.0-beta1-20160429-01"
  },
  "imports": [ "dnxcore50", "portable-net45+win8" ]
}

@russcam
Copy link
Contributor

russcam commented Jun 22, 2016

I've pulled this into the dotnet-rc2 branch and also updated the FAKE build scripts to use the new tooling.

@russcam
Copy link
Contributor

russcam commented Jun 23, 2016

All unit tests and integration tests pass on the dotnet-rc2 branch

.\build.bat
.\build.bat Integrate 5.0.0-alpha3

@tugberkugurlu
Copy link
Contributor

Is there any updates on this to get it to .NET Core 1.0.0?

@russcam
Copy link
Contributor

russcam commented Jul 4, 2016

@tugberkugurlu Yes, we're looking to put out a release this week

@gmarz
Copy link
Contributor

gmarz commented Jul 6, 2016

Closing in favor of #2149

@gmarz gmarz closed this Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants