Support for multi search template #2228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarz
force-pushed
the
feature/msearch-template
branch
from
771eaf5 to
2ab31e7
Compare
| var withMeta = multiSearch != null | ||
| ? docsJarray.Zip(multiSearch.Operations, (doc, desc) => new MultiHitTuple { Hit = doc, Descriptor = new KeyValuePair<string, ICovariantSearchRequest>(desc.Key, desc.Value) }) | ||
| : docsJarray.Zip(multiSearchTemplate.Operations, (doc, desc) => new MultiHitTuple { Hit = doc, Descriptor = new KeyValuePair<string, ICovariantSearchRequest>(desc.Key, desc.Value) }); | ||
|
|
||
| var originalResolver = serializer.ContractResolver; |
There was a problem hiding this comment.
Doesn't look originalResolver is used
|
A few small nitpicks and a question; I tried passing public IMultiSearchResponse MultiSearchTemplate(IMultiSearchTemplateRequest request)
{
return this.Dispatcher.Dispatch<IMultiSearchTemplateRequest, MultiSearchTemplateRequestParameters, MultiSearchResponse>(
request,
(p, d) =>
{
var converter = CreateMultiSearchTemplateDeserializer(p);
var serializer = this.ConnectionSettings.StatefulSerializer(converter);
//var json = serializer.SerializeToBytes(p).Utf8String();
var creator = new MultiSearchTemplateCreator((r, s) => serializer.Deserialize<MultiSearchResponse>(s));
request.RequestParameters.DeserializationOverride(creator);
return this.LowLevelDispatch.MsearchTemplateDispatch<MultiSearchResponse>(p, (object)p);
}
);
}and the unit and integration tests were happy, but I may be missing something. LGTM otherwise 👍 |
code review fixes
gmarz
force-pushed
the
feature/msearch-template
branch
from
2ab31e7 to
42fa133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.elastic.co/guide/en/elasticsearch/reference/master/multi-search-template.html