Skip to content

Fix NRE when deserializing a multi bucket aggregate with an empty buc… #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2016
Merged

Fix NRE when deserializing a multi bucket aggregate with an empty buc… #2274

merged 1 commit into from
Sep 21, 2016

Conversation

gmarz
Copy link
Contributor

@gmarz gmarz commented Sep 21, 2016 •
edited
Loading

…kets object

Another reason to justify #2081 :) /cc @elastic/microsoft

Mpdreamz
Mpdreamz approved these changes Sep 21, 2016
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LgTM but I do not like the reproduce test, it should be something placed near the multi bucket aggs test. Need to sync on how we want to add tests like these in the future. Not a blocker for thisnPR though 👍

@gmarz gmarz merged commit 1ecaf8d into 2.x Sep 21, 2016
@gmarz gmarz deleted the fix/aggs-nre branch September 21, 2016 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmarz @Mpdreamz