Skip to content

Fix script representation for bulk updates #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2016
Merged

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Nov 7, 2016

Parameters related to an update script should be serialized as properties of an object assigned to a script property.
Closes #2357

@russcam russcam added the v2.4.7 label Nov 7, 2016
public BulkUpdateDescriptor<TDocument, TPartialDocument> RetriesOnConflict(int? retriesOnConflict) => Assign(a => a.RetriesOnConflict = retriesOnConflict);

private IScript CreateScriptFromProperties()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pragmatic fix++;

@russcam russcam force-pushed the fix/2.x-bulk-update-script branch from 768dbc1 to 49b3c43 Compare November 9, 2016 02:10
Parameters related to an update script should be serialized as properties of an object assigned to a script property.
Closes #2357
@russcam russcam merged commit 49b3c43 into 2.x Nov 9, 2016
@russcam russcam deleted the fix/2.x-bulk-update-script branch November 24, 2016 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants