Skip to content

sliced scroll support #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2016
Merged

sliced scroll support #2436

merged 1 commit into from
Nov 30, 2016

Conversation

Mpdreamz
Copy link
Member

@@ -399,6 +405,12 @@ public partial class SearchDescriptor<T> where T : class
Assign(a => a.Query = query?.Invoke(new QueryContainerDescriptor<T>()));

/// <summary>
/// For scroll queries that return a lot of documents it is possible to split the scroll in multiple slices which can be consumed independently
/// </summary>
public SearchDescriptor<T> Slice(Func<SlicedScrollDescriptor<T>, ISlicedScroll> query) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Func should be named selector

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@gmarz gmarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz force-pushed the feature/sliced-scroll branch from 1eb65e0 to ded74c6 Compare November 30, 2016 19:53
@Mpdreamz Mpdreamz merged commit 83c4f87 into 5.x Nov 30, 2016
@Mpdreamz Mpdreamz deleted the feature/sliced-scroll branch November 30, 2016 19:54
Mpdreamz added a commit that referenced this pull request Nov 30, 2016
@Mpdreamz
Copy link
Member Author

ported to master and did the rename in a separate commit

awelburn pushed a commit to Artesian/elasticsearch-net that referenced this pull request Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants