fix #2448 favor publish_address in 5.x #2468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarz
approved these changes
Dec 7, 2016
| @@ -5,13 +5,29 @@ | |||
|
|
|||
| namespace Elasticsearch.Net | |||
| { | |||
| public class SniffResponse | |||
| public static class SniffParser | |||
|
In the which will yield and in 2.x the http section of the response returns the same value for "http" : {
"bound_address" : [ "127.0.0.1:9200", "[::1]:9200" ],
"publish_address" : "elastic.co/35.160.254.14:9200",
"max_content_length_in_bytes" : 104857600
}Which is why this does not need to be ported to 2.x as we do the right thing there already |
Mpdreamz
force-pushed
the
fix/publish_host
branch
from
9dba643 to
4e16dea
Compare
Now that 5.x no longer returns http_address we need to give precedence to `publish_address` over `bound_address`
Mpdreamz
added a commit
that referenced
this pull request
Dec 8, 2016
|
ported to |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
Now that 5.x no longer returns http_address we need to give precedence to `publish_address` over `bound_address`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that 5.x no longer returns http_address we need to give precedence
to
publish_addressoverbound_address