Skip to content

Limit the number of TCP connections on .NET core #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Dec 8, 2016

Give the same limit as in desktop clr. Might make sense to expose this as a configurable property in the future.
Remove the async action in the Parallel.For

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed it makes sense to make it configurable on IConnectionConfigurationValues now that both connections share this value 👍

@russcam
Copy link
Contributor Author

russcam commented Dec 9, 2016

@Mpdreamz @gmarz I've added a ConnectionLimit value to ConnectionConfiguration with a default value of 80. Also added comments for all options; thinking that we can include these on a documentation page as part of #2248

Copy link
Contributor

@gmarz gmarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam
Copy link
Contributor Author

russcam commented Dec 9, 2016

Rebasing and squashing

@russcam russcam force-pushed the fix/5.x-coreclr-connection-limit branch from 2692cca to db20fe3 Compare December 9, 2016 05:13
Remove the async action in the Parallel.For
Add ConnectionLimit to ConnectionConfiguration
Add comments to all options with clear descriptions.
@russcam russcam force-pushed the fix/5.x-coreclr-connection-limit branch from db20fe3 to 6546ed6 Compare December 9, 2016 05:16
@russcam russcam merged commit 6546ed6 into 5.x Dec 9, 2016
@Mpdreamz Mpdreamz deleted the fix/5.x-coreclr-connection-limit branch January 23, 2017 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants