Skip to content

Prevent multiple date time allocations #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2016
Merged

Prevent multiple date time allocations #2510

merged 1 commit into from
Dec 28, 2016

Conversation

niemyjski
Copy link
Contributor

  1. DateTime.SpecifyKind will return a new DateTime instance.
  2. Creating new DateTime instance for Epoch,
  3. Adding Milliseconds creates a new DateTime Instance

Now only one instance is created (apart from the one time static hit)

1. DateTime.SpecifyKind will return a new DateTime instance.
2. Creating new DateTime instance for Epoch,
3. Adding Milliseconds creates a new DateTime Instance

Now only one instance is created (apart from the one time static hit)
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @niemyjski

@Mpdreamz Mpdreamz merged commit e30f1ab into elastic:master Dec 28, 2016
Mpdreamz pushed a commit that referenced this pull request Dec 28, 2016
1. DateTime.SpecifyKind will return a new DateTime instance.
2. Creating new DateTime instance for Epoch,
3. Adding Milliseconds creates a new DateTime Instance

Now only one instance is created (apart from the one time static hit)
Mpdreamz pushed a commit that referenced this pull request Dec 28, 2016
1. DateTime.SpecifyKind will return a new DateTime instance.
2. Creating new DateTime instance for Epoch,
3. Adding Milliseconds creates a new DateTime Instance

Now only one instance is created (apart from the one time static hit)
@Mpdreamz
Copy link
Member

ported to 2.x and 5.x

@niemyjski niemyjski deleted the patch-1 branch December 28, 2016 14:41
awelburn pushed a commit to Artesian/elasticsearch-net that referenced this pull request Nov 6, 2017
1. DateTime.SpecifyKind will return a new DateTime instance.
2. Creating new DateTime instance for Epoch,
3. Adding Milliseconds creates a new DateTime Instance

Now only one instance is created (apart from the one time static hit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants