Support GeometryCollection geo_shape types and queries #2532
Conversation
| @@ -8,7 +8,7 @@ internal class GeoCoordinateJsonConverter : JsonConverter | |||
| public override bool CanConvert(Type objectType) => true; | |||
| public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer) | |||
| { | |||
| var p = value as GeoCoordinate; | |||
| var p = (GeoCoordinate)value; | |||
There was a problem hiding this comment.
Will this blow up if value isn't a GeoCoordinate? Not sure if the null check makes sense anymore with the direct cast.
There was a problem hiding this comment.
It would. yes 😄
My thinking for converting to a direct cast however is that the converter is internal so we have control over which types it is applied to, so we should only be applying it to GeoCoordinate. If it's applied to another type other than GeoCoordinate, I think it would be better to have the invalid cast exception (to fix) rather than swallowing. In addition, the direct cast will slightly faster than as, which is effectively an is check and then cast.
There was a problem hiding this comment.
++ but I don't think the null check makes sense anymore?
There was a problem hiding this comment.
The null check should still be there because it could be passed a null GeoCoordinate still
|
Minor comment, but otherwise LGTM. |
russcam
force-pushed
the
feature/5.x-geometrycollection
branch
from
30b7fd8 to
42dcf97
Compare
Tidy up xml comments on queries Fix warnings Closes #2387
russcam
force-pushed
the
feature/5.x-geometrycollection
branch
from
42dcf97 to
fe41648
Compare
Tidy up xml comments on queries
Fix warnings
Closes #2387