Add debugging mode to connection settings #2538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to set .EnableDebugMode() on ConnectionSettings which turns direct streaming and pretty JSON on and writes DebugInformation to the output window. It also accepts an optional Action<IApiCallDetails> to perform when the request is completed, but preserves the original OnRequestCompleted action that might be set on ConnectionSettings. Closes #2535
Mpdreamz
requested changes
Jan 16, 2017
| { | ||
| originalCompletedRequestHandler?.Invoke(d); | ||
| onRequestCompleted?.Invoke(d); | ||
| System.Diagnostics.Debug.WriteLine(d.DebugInformation); |
There was a problem hiding this comment.
I think we need to let the user do this in their delegate themselves
There was a problem hiding this comment.
Write to the debug output, or preserve the original request handler? Or both? :)
There was a problem hiding this comment.
I sort of like that we write to it automatically as part of "debug mode", but I see the argument against it. I'll remove it and update the PR 👍.
There was a problem hiding this comment.
Or we can make the default handler write the debug info, and let the user supplied one override it?
There was a problem hiding this comment.
done with my last commit
Mpdreamz
approved these changes
Jan 18, 2017
Mpdreamz
pushed a commit
that referenced
this pull request
Jan 18, 2017
* Add debugging mode to connection settings This commit adds the ability to set .EnableDebugMode() on ConnectionSettings which turns direct streaming and pretty JSON on and writes DebugInformation to the output window. It also accepts an optional Action<IApiCallDetails> to perform when the request is completed, but preserves the original OnRequestCompleted action that might be set on ConnectionSettings. Closes #2535 * move debug.write to default request completed handler
Mpdreamz
pushed a commit
that referenced
this pull request
Jan 18, 2017
* Add debugging mode to connection settings This commit adds the ability to set .EnableDebugMode() on ConnectionSettings which turns direct streaming and pretty JSON on and writes DebugInformation to the output window. It also accepts an optional Action<IApiCallDetails> to perform when the request is completed, but preserves the original OnRequestCompleted action that might be set on ConnectionSettings. Closes #2535 * move debug.write to default request completed handler
|
ported to |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
* Add debugging mode to connection settings This commit adds the ability to set .EnableDebugMode() on ConnectionSettings which turns direct streaming and pretty JSON on and writes DebugInformation to the output window. It also accepts an optional Action<IApiCallDetails> to perform when the request is completed, but preserves the original OnRequestCompleted action that might be set on ConnectionSettings. Closes elastic#2535 * move debug.write to default request completed handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to set .EnableDebugMode() on
ConnectionSettings which turns direct streaming and pretty JSON on and
writes DebugInformation to the output window.
It also accepts an optional Action to perform when the
request is completed, but preserves the original OnRequestCompleted action
that might be set on ConnectionSettings.
Closes #2535