added DateFormat constants with xmldocs #2544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
reviewed
Jan 19, 2017
| @@ -0,0 +1,162 @@ | |||
| namespace Nest.CommonOptions.DateFormat | |||
There was a problem hiding this comment.
namespace should be "Nest"
| public static class DateFormat | ||
| { | ||
| ///<summary>A formatter for the number of milliseconds since the epoch. Note, that this timestamp is subject to the limits of a Java Long.MIN_VALUE and Long.MAX_VALUE.</summary> | ||
| public const string epoch_millis = "epoch_mills"; |
There was a problem hiding this comment.
Strong opinions about using the original names v.s. idiomatic .NET Pascal casing?
There was a problem hiding this comment.
kinda :) EpochMillis(seconds) not that bad but turning strict_t_time into StrictTTIme :/ their is litttle guessing or ambiguity in keeping the casing which is a big plus over dogmatic casing, What do you guys reckon?
There was a problem hiding this comment.
I'm cool with using the original names.
gmarz
approved these changes
Jan 23, 2017
Mpdreamz
added a commit
that referenced
this pull request
Jan 25, 2017
Mpdreamz
added a commit
that referenced
this pull request
Jan 25, 2017
Conflicts: src/Nest/Nest.csproj
|
backported to |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #2493