Suggester fixes #2548
Merged
Suggester fixes #2548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Term and phrase suggesters return score as `score` we were expecting `_score` - `freq` missing for term suggestion options - Smoothing models missing from phrase suggestion request - Integration tests for suggestions now checks all three not just (context) completion on documents
gmarz
approved these changes
Jan 23, 2017
src/Nest/Nest.csproj
Outdated
| <Compile Include="Search\Suggesters\PhraseSuggester\PhraseSuggestCollate.cs" /> | ||
| <Compile Include="Search\Suggesters\PhraseSuggester\PhraseSuggester.cs" /> | ||
| <Compile Include="Search\Suggesters\PhraseSuggester\PhraseSuggestHighlight.cs" /> | ||
| <Compile Include="Search\Suggesters\PhraseSuggester\SmoothingModel\ LinearInterpolationSmoothingModel.cs" /> |
There was a problem hiding this comment.
Leading space in the file name
| internal double? SuggestScore { get; set; } | ||
|
|
||
| [JsonIgnore] | ||
| public double Score => DocumentScore ?? SuggestScore ?? 0; |
Mpdreamz
added a commit
that referenced
this pull request
Jan 25, 2017
* Suggester fixes - Term and phrase suggesters return score as `score` we were expecting `_score` - `freq` missing for term suggestion options - Smoothing models missing from phrase suggestion request - Integration tests for suggestions now checks all three not just (context) completion on documents * removed leading space in filename, nice catch @gmarz
|
backported to Implemented a new PR #2553 for the backport to 2.x since it does not need the changes to |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
* Suggester fixes - Term and phrase suggesters return score as `score` we were expecting `_score` - `freq` missing for term suggestion options - Smoothing models missing from phrase suggestion request - Integration tests for suggestions now checks all three not just (context) completion on documents * removed leading space in filename, nice catch @gmarz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scorewe were expecting_scorefreqmissing for term suggestion options