Fix for covariant search date parsing #2643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where indexing dates as strings and pulling them back out using covariant search would result in the format being different due to the default DateParseHandling serialization settings. ConcereteTypeConverter now temporarily sets DateParseHandling to None when deserializing covariant results.
Mpdreamz
approved these changes
Mar 1, 2017
| @@ -94,7 +94,10 @@ internal static class ConcreteTypeConverter | |||
|
|
|||
| private static JObject CreateIntermediateJObject(JsonReader reader) | |||
| { | |||
| var original = reader.DateParseHandling; | |||
| reader.DateParseHandling = DateParseHandling.None; | |||
There was a problem hiding this comment.
Add a comment why we feel this is not side effecty.
There was a problem hiding this comment.
Great fix. ++ on adding a comment.
Quick question, where do we use the StatefulDeserialization class? Only for Covariant Search type? Just trying to understand whether this can affect other functionality.
There was a problem hiding this comment.
CovariantSearch needs ConcreteTypeConverter, in order to create an isolated serializer that has access to state we call the Stateful deserialization factory on ISerializerFactory and we append a new instance of ConcreteTypeConverter. Search/MultiGet/MultiSearch/SearchTemplate all possibly call this (but only if needed)
gmarz
added a commit
that referenced
this pull request
Mar 2, 2017
* Fix for covariant search date parsing This commit fixes an issue where indexing dates as strings and pulling them back out using covariant search would result in the format being different due to the default DateParseHandling serialization settings. ConcereteTypeConverter now temporarily sets DateParseHandling to None when deserializing covariant results. * add comment explaining the fix
gmarz
added a commit
that referenced
this pull request
Mar 2, 2017
* Fix for covariant search date parsing This commit fixes an issue where indexing dates as strings and pulling them back out using covariant search would result in the format being different due to the default DateParseHandling serialization settings. ConcereteTypeConverter now temporarily sets DateParseHandling to None when deserializing covariant results. * add comment explaining the fix
|
Merged to 2.x, 5.x, and master |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
* Fix for covariant search date parsing This commit fixes an issue where indexing dates as strings and pulling them back out using covariant search would result in the format being different due to the default DateParseHandling serialization settings. ConcereteTypeConverter now temporarily sets DateParseHandling to None when deserializing covariant results. * add comment explaining the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where indexing dates as strings and pulling
them back out using covariant search would result in the format being
different due to the default DateParseHandling serialization settings.
ConcereteTypeConverter now temporarily sets DateParseHandling to None
when deserializing covariant results.
/cc @gmoskovicz