Skip to content

Conversation

Mpdreamz
Copy link
Member

No description provided.

Copy link
Contributor

@gmarz gmarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz force-pushed the feature/scripted-upsert-2.x branch from 529424e to 305c928 Compare March 20, 2017 13:39
@Mpdreamz Mpdreamz merged commit 8bd0462 into 2.x Mar 20, 2017
Mpdreamz added a commit that referenced this pull request Mar 20, 2017
Mpdreamz added a commit that referenced this pull request Mar 20, 2017
internal IScript _Script { get; set; }

[JsonProperty("scripted_upsert")]
public bool? _ScriptedUpsert { get; set; }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be internal

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 72f058f

@Mpdreamz
Copy link
Member Author

ported to 5.x and master

@Mpdreamz Mpdreamz deleted the feature/scripted-upsert-2.x branch March 20, 2017 17:45
awelburn pushed a commit to Artesian/elasticsearch-net that referenced this pull request Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants