add support for RemoteInfo API and adds cross cluster support to Inde… #2743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically |
russcam
approved these changes
May 4, 2017
| { | ||
| var enableRemoteClusters = client.ClusterPutSettings(new ClusterPutSettingsRequest | ||
| { | ||
| Transient = new M |
There was a problem hiding this comment.
I think it's be better to use the type here instead of the M alias, for documentation purposes
| public partial interface IElasticClient | ||
| { | ||
| /// <summary> | ||
| /// The cluster health API allows to get a very simple status on the health of the cluster. |
There was a problem hiding this comment.
I think this should use the remote info API summary?
The cluster remote info API allows to retrieve all of the configured remote cluster information.
| private static readonly char[] ClusterSeparator = {':'}; | ||
| internal string DebugDisplay => Type == null ? Name : $"{nameof(IndexName)} for typeof: {Type?.Name}"; | ||
|
|
||
| //TODO 6.0 make setters private and use constructor |
Mpdreamz
added a commit
that referenced
this pull request
May 4, 2017
|
Implemented PR feedback as part of |
Merged
Mpdreamz
added a commit
that referenced
this pull request
May 4, 2017
Mpdreamz
added a commit
that referenced
this pull request
May 4, 2017
* Updated api gen to 5.4 and added a way to patch specification files through special *.patch.json companion files. Due to pending discusion on elastic/elasticsearch@e579629 :q! * updated x-pack spec to 5.4 * add codegen part for xpack info related APIs * Added support for Field Caps API * add support for RemoteInfo API and adds cross cluster support to IndexName * added support for SourceExists() * add skipversion, eventhough this API existed it was undocumented prior to 5.4 * expose word delimiter graph token filter as per elastic/elasticsearch#23327 * spaces=>tabs * expose num_reduce_phases as per elastic/elasticsearch#23288 * implemented XPackInfo() started on XPackUsage() * added response structure for XPackUsage() * change license date from DateTime to DateTimeOffset' * implement PR feedback on #2743 * remove explicit folder includes in csproj files
|
ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xName