Skip to content

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented May 1, 2017

No description provided.

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one small comment

public Fields SourceExclude { get { return Q<Fields>("_source_exclude"); } set { Q("_source_exclude", value); } }

///<summary>A list of fields to extract and return from the _source field</summary>
public Fields SourceInclude { get { return Q<Fields>("_source_include"); } set { Q("_source_include", value); } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the Source* properties valid on this type of request?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are :) Threw me initially as well.

@Mpdreamz Mpdreamz merged commit 455ac3d into 5.4 May 4, 2017
@Mpdreamz Mpdreamz deleted the feature/source-exists branch May 4, 2017 09:08
@Mpdreamz Mpdreamz mentioned this pull request May 4, 2017
@Mpdreamz
Copy link
Member Author

Mpdreamz commented May 4, 2017

ported to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants