can now map clr types dynamically on connection settings including an… #2934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Dec 13, 2017
| /// <summary> | ||
| /// When specified allows you to ignore or rename certain properties of clr type <typeparamref name="T" /> | ||
| /// </summary> | ||
| public IList<IPocoPropertyMapping<T>> Properties { get; set; } |
There was a problem hiding this comment.
Should the non-generic PocoMapping also expose a Properties collection, since ultimately the properties are added to a FluentDictionary<MemberInfo, IPropertyMapping>?
|
|
||
| namespace Nest | ||
| { | ||
| public interface IPocoMapping |
There was a problem hiding this comment.
I thought ClrTypeMapping was fairly descriptive 😄
… overload that takes a list of mappings to ease more dynamic configuration of types at run time
russcam
force-pushed
the
feature/non-generic-poco-infer-mapping
branch
from
f8990ce to
ce11271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… overload that takes a list of mappings to ease more dynamic configuration of types at run time
fixes: #2926