Include similarity in index settings (#2924) #2966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
commented
Dec 20, 2017
|
|
||
| public DefaultSimilarityDescriptor DiscountOverlaps(bool? discount = true) => Assign(a => a.DiscountOverlaps = discount); | ||
| /// <inheritdoc /> | ||
| public DefaultSimilarityDescriptor DiscountOverlaps(bool discount = true) => Assign(a => a.DiscountOverlaps = discount); |
There was a problem hiding this comment.
Needs to be changed to bool? to maintain binary compatibility
codebrain
reviewed
Dec 20, 2017
| /// BM25 Similarity. Introduced in Stephen E. Robertson, Steve Walker, Susan Jones, Micheline Hancock-Beaulieu, | ||
| /// and Mike Gatford. Okapi at TREC-3. In Proceedings of the Third Text REtrieval Conference (TREC 1994). Gaithersburg, USA, November 1994. | ||
| /// BM25 Similarity. Introduced in Stephen E. Robertson, Steve Walker, Susan Jones, Micheline Hancock-Beaulieu, | ||
| /// and Mike Gatford. Okapi at TREC-3. In Proceedings of the Third Text Retrieval Conference (TREC 1994). Gaithersburg, USA, November 1994. |
codebrain
approved these changes
Dec 20, 2017
|
|
||
| public DefaultSimilarityDescriptor DiscountOverlaps(bool? discount = true) => Assign(a => a.DiscountOverlaps = discount); | ||
| /// <inheritdoc /> | ||
| public DefaultSimilarityDescriptor DiscountOverlaps(bool discount = true) => Assign(a => a.DiscountOverlaps = discount); |
| var timeout = TimeSpan.FromSeconds(420); | ||
| var handle = new XplatManualResetEvent(false); | ||
| Task.Run(() => | ||
| var task = Task.Run(() => |
| { | ||
| discount_overlaps = true, | ||
| type = "default" | ||
| type = "classic" |
There was a problem hiding this comment.
This should be default here in 2.x, not "classic"
There was a problem hiding this comment.
Mpdreamz
requested changes
Dec 21, 2017
| { | ||
| discount_overlaps = true, | ||
| type = "default" | ||
| type = "classic" |
There was a problem hiding this comment.
Non binary breaking back port of 648c3cf Similarity settings are nested under settings>index Add ClassicSimilarity Add DFISimilarity Add similarity settings to create index integration tests Add XML comments for each similarity Refactor SimilarityJsonConverter to not look up the NEST ISimilarity type with Type.GetType() but to infer it from the type property value directly. Add Similarity to the updatable index settings Closes #2890 (cherry picked from commit bf78582)
russcam
force-pushed
the
fix/2.x-similarities
branch
from
753766d to
5d98435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non binary breaking back port of 648c3cf
Similarity settings are nested under settings>index
Add ClassicSimilarity
Add DFISimilarity
Add similarity settings to create index integration tests
Add XML comments for each similarity
Refactor SimilarityJsonConverter to not look up the NEST ISimilarity type with Type.GetType() but to infer it from the type property value directly.
Add Similarity to the updatable index settings
Closes #2890
(cherry picked from commit bf78582)