fix #3116 instances of gethashcode in equals implementation #3117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
force-pushed
the
fix/types-equals
branch
from
7825e2e to
91fc730
Compare
russcam
suggested changes
Mar 2, 2018
| ) | ||
| ); | ||
| } | ||
|
|
||
| private static bool EqualsAllIndices(IReadOnlyList<IndexName> indicesCurrent, IReadOnlyList<IndexName> indicesOther) |
There was a problem hiding this comment.
thisIndices and otherIndices?
| if (indicesCurrent == null && indicesOther == null) return true; | ||
| if (indicesCurrent == null || indicesOther == null) return false; | ||
| if (indicesCurrent.Count != indicesOther.Count) return false; | ||
| return indicesCurrent.Zip(indicesOther, Tuple.Create).All(t=>t.Item1.Equals(t.Item2)); |
There was a problem hiding this comment.
I think this should also take into account the order of indices e.g.
Indices indices1 = "foo,bar";
Indices indices2 = "bar,foo";
(indices1 == indices2).Should().BeTrue();| ) | ||
| ); | ||
| } | ||
|
|
||
| private static bool EqualsAllTypes(IReadOnlyList<TypeName> indicesCurrent, IReadOnlyList<TypeName> indicesOther) |
| if (indicesCurrent == null && indicesOther == null) return true; | ||
| if (indicesCurrent == null || indicesOther == null) return false; | ||
| if (indicesCurrent.Count != indicesOther.Count) return false; | ||
| return indicesCurrent.Zip(indicesOther, Tuple.Create).All(t=>t.Item1.Equals(t.Item2)); |
There was a problem hiding this comment.
I think this should also take into account the order
|
All good points @russcam, addressed them in followup commit. |
Mpdreamz
added a commit
that referenced
this pull request
Mar 6, 2018
* fix #3116 instances of gethashcode in equals implementation * Equals on types and indices now ignores order and implements == operator Conflicts: src/Nest/CommonAbstractions/Infer/RelationName/RelationName.cs src/Tests/ClientConcepts/HighLevel/Inference/TypesAndRelationsInference.doc.cs src/Tests/Framework/Configuration/Versions/ElasticsearchVersion.cs src/Tests/Framework/ElasticsearchVersionTests.cs
Mpdreamz
added a commit
that referenced
this pull request
Mar 6, 2018
* fix #3116 instances of gethashcode in equals implementation * Equals on types and indices now ignores order and implements == operator Conflicts: src/Nest/CommonAbstractions/Infer/Indices/Indices.cs src/Nest/CommonAbstractions/Infer/Types/Types.cs
|
backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.