Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CodeGeneration/ApiGenerator/ApiGenerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ private static Dictionary<string, ApiQueryParameters> CreateCommonApiQueryParame
var json = File.ReadAllText(jsonFile);
var jobject = JObject.Parse(json);
var commonParameters = jobject.Property("params").Value.ToObject<Dictionary<string, ApiQueryParameters>>();
return ApiQueryParametersPatcher.Patch(commonParameters, null, checkCommon: false);
return ApiQueryParametersPatcher.Patch(null, commonParameters, null, checkCommon: false);
}

private static string CreateMethodName(string apiEndpointKey)
Expand Down
2 changes: 1 addition & 1 deletion src/CodeGeneration/ApiGenerator/Domain/ApiEndpoint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ private void PatchEndpoint()

private void PatchRequestParameters(IEndpointOverrides overrides)
{
var newParams = ApiQueryParametersPatcher.Patch(this.Url.Params, overrides);
var newParams = ApiQueryParametersPatcher.Patch(this.Url.Path, this.Url.Params, overrides);
this.Url.Params = newParams;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ public static class ApiQueryParametersPatcher
{

public static Dictionary<string, ApiQueryParameters> Patch(
string urlPath,
IDictionary<string, ApiQueryParameters> source,
IEndpointOverrides overrides,
bool checkCommon = true)
Expand All @@ -25,7 +26,7 @@ public static Dictionary<string, ApiQueryParameters> Patch(
var obsoleteLookup = CreateObsoleteLookup(globalOverrides, overrides, declaredKeys);

var patchedParams = new Dictionary<string, ApiQueryParameters>();
var name = overrides?.GetType().Name ?? "unkown";
var name = overrides?.GetType().Name ?? urlPath ?? "unknown";
foreach (var kv in source)
{
var queryStringKey = kv.Key;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
}
},
"body": {
"description": "The settings to be updated. Can be either `transient` or `persistent` (survives cluster restart)."
"description": "The settings to be updated. Can be either `transient` or `persistent` (survives cluster restart).",
"required" : true
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,6 @@
"type" : "time",
"description" : "Explicit operation timeout"
},
"timestamp": {
"type" : "time",
"description" : "Explicit timestamp for the document"
},
"ttl": {
"type" : "time",
"description" : "Expiration time for the document"
},
"version" : {
"type" : "number",
"description" : "Explicit version number for concurrency control"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,6 @@
"type" : "time",
"description" : "Explicit operation timeout"
},
"timestamp": {
"type" : "time",
"description" : "Explicit timestamp for the document"
},
"ttl": {
"type" : "time",
"description" : "Expiration time for the document"
},
"version" : {
"type" : "number",
"description" : "Explicit version number for concurrency control"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
},
"name": {
"type" : "list",
"required" : true,
"description" : "A comma-separated list of alias names to return"
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
"options" : ["open","closed","none","all"],
"default" : "closed",
"description" : "Whether to expand wildcard expression to concrete indices that are open, closed or both."
},
"wait_for_active_shards": {
"type" : "string",
"description" : "Sets the number of active shards to wait for before the operation returns."
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
"pre_filter_shard_size" : {
"type" : "number",
"description" : "A threshold that enforces a pre-filter roundtrip to prefilter search shards based on query rewriting if the number of shards the search request expands to exceeds the threshold. This filter roundtrip can limit the number of shards significantly if for instance a shard can not match any documents based on it's rewrite method ie. if date filters are mandatory to match but the shard bounds and the query are disjoint.",
"description" : "A threshold that enforces a pre-filter roundtrip to prefilter search shards based on query rewriting if the number of shards the search request expands to exceeds the threshold. This filter roundtrip can limit the number of shards significantly if for instance a shard can not match any documents based on it's rewrite method ie. if date filters are mandatory to match but the shard bounds and the query are disjoint.",
"default" : 128
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"parts": {
"task_id": {
"type": "string",
"required" : true,
"description": "The task id to rethrottle"
}
},
Expand Down
Loading