Update specs and APIs to 6.1 #3180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates to using the 6.1 core Rest API specification and regenerates the client with this. Adds wait_for_active_shards to OpenIndex API Include parameterless constructors for AliasExists, GetTask and ReindexRethrottle Closes #3153
This commit adds the Split Index API. number_of_routing_shards index setting added to support splitting. Closes #3154
WIP. Fix remaining unit tests
This commit moves the DeprecationInfo API and associated tests to a Migration directory under XPack, to align with X-Pack documentation
This commit adds Migration assistance and upgrade APIs. Consider including a 5.6 index for integration test purposes in future.
This commit adds the Get Trial License Status and Start Trial License APIs. Integration tests currently run against an X-Pack cluster that already has a valid license applied, so test the unhappy path.
This commit adds the machine learning Forecast Job API
This commit adds the machine learning overall buckets API. The integration test is similar to that performed within X-Pack integration.
This commit adds the EarliestRecordTimestamp and LatestRecordTimestamp to the PostJobDataResponse.
Use an IP address within the ranges that has better likelihood of partitioning addresses into buckets
Directive is not honoured when surrounding only some methods
This commit serializes IndicesBoost as an array of objects such that the boosts are ordered. Deserialization supports both JSON array and object forms Closes #3179
|
branch has been rebased against 6.x. I would suggest this branch is rebased and merge to allow the Migration assistance and upgrade APIs to be cherry-picked to 5.x |
This was referenced Mar 29, 2018
codebrain
approved these changes
Apr 5, 2018
| @@ -31,7 +31,7 @@ | |||
| }, | |||
| "pre_filter_shard_size" : { | |||
| "type" : "number", | |||
| "description" : "A threshold that enforces a pre-filter roundtrip to prefilter search shards based on query rewriting if the number of shards the search request expands to exceeds the threshold. This filter roundtrip can limit the number of shards significantly if for instance a shard can not match any documents based on it's rewrite method ie. if date filters are mandatory to match but the shard bounds and the query are disjoint.", | |||
| "description" : "A threshold that enforces a pre-filter roundtrip to prefilter search shards based on query rewriting if the number of shards the search request expands to exceeds the threshold. This filter roundtrip can limit the number of shards significantly if for instance a shard can not match any documents based on it's rewrite method ie. if date filters are mandatory to match but the shard bounds and the query are disjoint.", | |||
There was a problem hiding this comment.
will remove from downloaded spec
| @@ -1921,7 +1921,7 @@ public class SearchRequestParameters : RequestParameters<SearchRequestParameters | |||
| ///</summary> | |||
| public long? MaxConcurrentShardRequests { get => Q<long?>("max_concurrent_shard_requests"); set => Q("max_concurrent_shard_requests", value); } | |||
| ///<summary> | |||
| /// A threshold that enforces a pre-filter roundtrip to prefilter search shards based on query rewriting if the number of shards the search | |||
| /// A threshold that enforces a pre-filter roundtrip to prefilter search shards based on query rewriting if the number of shards the search | |||
| @@ -235,6 +235,7 @@ public IEnumerable<Constructor> DescriptorConstructors() | |||
| generated = $"public {m}({par}) : base({routing}.Required(\"type\", (Types)typeof({generic})))"; | |||
| } | |||
|
|
|||
| // TODO: Don't think this is required anymore, now that Suggest in on search endpoint. | |||
Suggest is no under the Search endpoint, so this commit removes the special case handling for generating SuggestDescriptor
Following PR review
|
Will need to be forward ported to master (without the bwc fixes for parameterless ctors) and the migration APIs backported to 5.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the 6.x branch with new REST APIs available in 6.1:
A number of deprecations are fixed:
A number of changes are made in relation to changes in the REST API specs, in order to maintain backwards binary compatibility:
Fixes the following tests