Update REST API json specifications to 6.2 #3268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also includes running the API Generator tool to create the C# code. |
russcam
suggested changes
Jun 1, 2018
There was a problem hiding this comment.
I left some comments re: binary breaking changes.
In my opinion, values on the public REST API spec, including query string parameters, should not be removed in a minor version. This includes query string parameters because of the validation applied when Elasticsearch receives a value it does not know about.
| @@ -6537,8 +6563,6 @@ public partial class ValidateQueryRequest<T> : PlainRequestBase<ValidateQueryReq | |||
| public bool? AllowNoIndices { get => Q<bool?>("allow_no_indices"); set => Q("allow_no_indices", value); } | |||
| ///<summary>Whether to expand wildcard expression to concrete indices that are open, closed or both.</summary> | |||
| public ExpandWildcards? ExpandWildcards { get => Q<ExpandWildcards?>("expand_wildcards"); set => Q("expand_wildcards", value); } | |||
| ///<summary>TODO: ?</summary> | |||
There was a problem hiding this comment.
Needs to be patched back in, in order to not break binary compatibility
| @@ -6588,8 +6612,6 @@ public partial class ValidateQueryRequest : PlainRequestBase<ValidateQueryReques | |||
| public bool? AllowNoIndices { get => Q<bool?>("allow_no_indices"); set => Q("allow_no_indices", value); } | |||
| ///<summary>Whether to expand wildcard expression to concrete indices that are open, closed or both.</summary> | |||
| public ExpandWildcards? ExpandWildcards { get => Q<ExpandWildcards?>("expand_wildcards"); set => Q("expand_wildcards", value); } | |||
| ///<summary>TODO: ?</summary> | |||
| public string OperationThreading { get => Q<string>("operation_threading"); set => Q("operation_threading", value); } | |||
There was a problem hiding this comment.
Needs to be patched back in, in order to not break binary compatibility
| @@ -5438,12 +5466,10 @@ public partial class SegmentsRequest : PlainRequestBase<SegmentsRequestParameter | |||
| public bool? AllowNoIndices { get => Q<bool?>("allow_no_indices"); set => Q("allow_no_indices", value); } | |||
| ///<summary>Whether to expand wildcard expression to concrete indices that are open, closed or both.</summary> | |||
| public ExpandWildcards? ExpandWildcards { get => Q<ExpandWildcards?>("expand_wildcards"); set => Q("expand_wildcards", value); } | |||
| ///<summary>TODO: ?</summary> | |||
| public string OperationThreading { get => Q<string>("operation_threading"); set => Q("operation_threading", value); } | |||
There was a problem hiding this comment.
Needs to be patched back in, in order to not break binary compatibility
| @@ -3825,10 +3823,8 @@ public partial class IndicesShardStoresRequest : PlainRequestBase<IndicesShardSt | |||
| public bool? AllowNoIndices { get => Q<bool?>("allow_no_indices"); set => Q("allow_no_indices", value); } | |||
| ///<summary>Whether to expand wildcard expression to concrete indices that are open, closed or both.</summary> | |||
| public ExpandWildcards? ExpandWildcards { get => Q<ExpandWildcards?>("expand_wildcards"); set => Q("expand_wildcards", value); } | |||
| ///<summary>TODO: ?</summary> | |||
| public string OperationThreading { get => Q<string>("operation_threading"); set => Q("operation_threading", value); } | |||
There was a problem hiding this comment.
Needs to be patched back in, in order to not break binary compatibility
| ///<summary>TODO: ?</summary> | ||
| public string OperationThreading { get => Q<string>("operation_threading"); set => Q("operation_threading", value); } | ||
| ///<summary>Specify whether the request should block until the merge process is finished (default: true)</summary> | ||
| public bool? WaitForMerge { get => Q<bool?>("wait_for_merge"); set => Q("wait_for_merge", value); } |
There was a problem hiding this comment.
Needs to be patched back in, in order to not break binary compatibility
| @@ -2701,12 +2703,8 @@ public partial class ForceMergeRequest : PlainRequestBase<ForceMergeRequestParam | |||
| public long? MaxNumSegments { get => Q<long?>("max_num_segments"); set => Q("max_num_segments", value); } | |||
| ///<summary>Specify whether the operation should only expunge deleted documents</summary> | |||
| public bool? OnlyExpungeDeletes { get => Q<bool?>("only_expunge_deletes"); set => Q("only_expunge_deletes", value); } | |||
| ///<summary>TODO: ?</summary> | |||
| public string OperationThreading { get => Q<string>("operation_threading"); set => Q("operation_threading", value); } | |||
There was a problem hiding this comment.
Needs to be patched back in, in order to not break binary compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.