Add scroll parameter to reindex. Closes #3253 #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
reviewed
Jun 14, 2018
| @@ -10,9 +10,9 @@ | |||
|
|
|||
| namespace Elasticsearch.Net | |||
| { | |||
|
|
|||
codebrain
commented
Jun 14, 2018
| @@ -1835,30 +1835,32 @@ public class ReindexOnServerRequestParameters : RequestParameters<ReindexOnServe | |||
| public long? RequestsPerSecond { get => Q<long?>("requests_per_second"); set => Q("requests_per_second", value); } | |||
| ///<summary>The number of slices this task should be divided into. Defaults to 1 meaning the task isn't sliced into subtasks.</summary> | |||
| public long? Slices { get => Q<long?>("slices"); set => Q("slices", value); } | |||
| ///<summary>Specify how long a consistent view of the index should be maintained for scrolled search</summary> | |||
| public TimeSpan Scroll { get => Q<TimeSpan>("scroll"); set => Q("scroll", value); } | |||
There was a problem hiding this comment.
@russcam - the needle in the haystack. This is the change.
russcam
approved these changes
Jun 14, 2018
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for all of the white space noise in the pull request, looks like it was added from the re-gen.
Added a patch file to the local json spec, awaiting fix in
elasticsearchrepo: elastic/elasticsearch#31316