Fix #3404 bulk all improvements #3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncountered. Now defaults to halting the BulkAll which is a saner default
…ptionally bails out early
Mpdreamz
added a commit
that referenced
this pull request
Sep 18, 2018
* Add more explicit support for what to do when dropped documents are encountered. Now defaults to halting the BulkAll which is a saner default * fix audit reporting negative durations * Add FailedOverOnAllNodes audit event * BulkAll now handles bad responses from the _bulk itself as well and optionally bails out early * Fixed tests now excepting FailedOverAllNodes * ContinueAfterDroppedDocuments should not be tested for nullable arg in the code standards test (cherry picked from commit ec5ef6f)
Mpdreamz
added a commit
that referenced
this pull request
Sep 18, 2018
* Add more explicit support for what to do when dropped documents are encountered. Now defaults to halting the BulkAll which is a saner default * fix audit reporting negative durations * Add FailedOverOnAllNodes audit event * BulkAll now handles bad responses from the _bulk itself as well and optionally bails out early * Fixed tests now excepting FailedOverAllNodes * ContinueAfterDroppedDocuments should not be tested for nullable arg in the code standards test (cherry picked from commit ec5ef6f)
|
backported to |
|
Introduces a couple of adjustments, the predicate was checking Another change is that the This change is now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
BulkAll()implementation was written to steamroll its way to completion. This leads to a lot of unnecessary request in the case where most documents are expected to fail e.g due to a bad mapping.This assumption is not clear from the contract nor our docs hence the bug label.
This PR halts
BulkAll()if any documents with errors are returned that can not be retried.It also halts or retries based on the
_bulkrequests status itself.It introduces a more explicit
FailedOverAllNodesaudit event which currently bubbles out as aMaxRetriesonly.Finally you can opt in to the streamroll by setting
ContinueAfterDroppedDocumentsto true which will feed all documents it can not retry to an optionalDroppedDocumentCallbackwhich can put it in a DLQ for instance.