rollup job crud apis #3448
Merged
rollup job crud apis #3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
suggested changes
Oct 16, 2018
| [JsonProperty("index_pattern")] | ||
| public string IndexPattern { get; internal set; } | ||
|
|
||
| /// <inheritdoc cref="ICreateRollupJobRequest.RollupIndex"> |
There was a problem hiding this comment.
<inheritdoc /> needs to be self-closing
| [JsonProperty("rollup_index")] | ||
| public IndexName RollupIndex { get; internal set; } | ||
|
|
||
| /// <inheritdoc cref="ICreateRollupJobRequest.Cron"> |
There was a problem hiding this comment.
<inheritdoc /> needs to be self-closing
| [JsonProperty("cron")] | ||
| public string Cron { get; internal set; } | ||
|
|
||
| /// <inheritdoc cref="ICreateRollupJobRequest.PageSize"> |
There was a problem hiding this comment.
<inheritdoc /> needs to be self-closing
| [JsonProperty("page_size")] | ||
| public long? PageSize { get; internal set; } | ||
|
|
||
| /// <inheritdoc cref="ICreateRollupJobRequest.Groups"> |
There was a problem hiding this comment.
<inheritdoc /> needs to be self-closing
| // "xpack.rollup.get_jobs.json", | ||
| // "xpack.rollup.put_job.json", | ||
| // "xpack.rollup.start_job.json", | ||
| // "xpack.rollup.stop_job.json", |
| { | ||
| public partial interface IElasticClient | ||
| { | ||
| /// <inheritdoc/> |
There was a problem hiding this comment.
I think this should have a <summary>...</summary> and all other overloads inheritdoc from it
| { | ||
| public partial interface IElasticClient | ||
| { | ||
| /// <inheritdoc/> |
There was a problem hiding this comment.
I think this should have a <summary>...</summary> and all other overloads inheritdoc from it
| { | ||
| public partial interface IElasticClient | ||
| { | ||
| /// <inheritdoc/> |
There was a problem hiding this comment.
I think this should have a <summary>...</summary> and all other overloads inheritdoc from it
russcam
approved these changes
Oct 17, 2018
russcam
pushed a commit
that referenced
this pull request
Oct 26, 2018
This commit adds support for the Rollup APIs: - CreateRollupJob - GetRollupJob - DeleteRollupJob - StartRollupJob - StopRollupJob - GetRollupCapabilities - RollupSearch (cherry picked from commit 4cb05c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the rollup job crud API's
As well as: