Skip to content

Add rollup capibilities API #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 18, 2018
Merged

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Oct 5, 2018

pending #3449

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments. Looks like URL tests are also missing?

{
public partial interface IElasticClient
{
/// <inheritdoc/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should have a <summary> and other overloads inherit from it

GetRollupCapabilitiesDescriptor,
GetRollupCapabilitiesRequest,
IGetRollupCapabilitiesRequest,
IGetRollupCapabilitiesResponse>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation and formatting looks a little weird/off?

@russcam russcam merged commit faedf9c into feature/rollup-search Oct 18, 2018
@russcam russcam deleted the feature/rollup-caps branch October 18, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants