Return overloads that do not take format on Field in 6.x, #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em was a bwc breaking change
codebrain
approved these changes
Jan 15, 2019
|
Diff from this with <Type Name="Nest.Field" DiffType="Modified">
<DeclarationDiffs>
<CustomAttribute Name="Elastic.Internal.JsonNet.JsonConverterAttribute::.ctor(System.Type)" DiffType="New" />
<CustomAttribute Name="Nest.ContractJsonConverterAttribute::.ctor(System.Type)" DiffType="Deleted" />
</DeclarationDiffs>
<Property Name="Format" DiffType="New" />
<Method Name="Field(Expression, Nullable<Double>, String)" DiffType="New" />
<Method Name="Field(PropertyInfo, Nullable<Double>, String)" DiffType="New" />
<Method Name="Field(String, Nullable<Double>, String)" DiffType="New" />
<Method Name="And<T>(Expression<Func<T, Object>>, Nullable<Double>, String)" DiffType="New" />
<Method Name="And(PropertyInfo, Nullable<Double>, String)" DiffType="New" />
<Method Name="And(String, Nullable<Double>, String)" DiffType="New" />
</Type>The |
Mpdreamz
added a commit
that referenced
this pull request
Jan 24, 2019
* Return overloads that do not take format on Field in 6.x, removing them was a bwc breaking change * Remove ambiguity on Field constructor and Field static methods on Infer * Fixed overload of Field on static infer still being nullable, and chain methods And on Field * string overload on field constructor needed fixing too
Mpdreamz
added a commit
that referenced
this pull request
Jan 25, 2019
* Return overloads that do not take format on Field in 6.x, removing them was a bwc breaking change * Remove ambiguity on Field constructor and Field static methods on Infer * Fixed overload of Field on static infer still being nullable, and chain methods And on Field * string overload on field constructor needed fixing too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing thm was a bwc breaking change.
cc @codebrain @russcam