Skip to content

Use the version number present in the global.json file when generating documentation #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2019
Merged

Use the version number present in the global.json file when generating documentation #3557

merged 1 commit into from
Mar 5, 2019

Conversation

codebrain
Copy link
Contributor

@codebrain codebrain commented Jan 30, 2019 •
edited
Loading

This pull request addresses an issue whereby the documentation can be generated for a release with the incorrect version number. The version number is now calculated from the global.json file, thereby limiting the chances of the incorrect version number being used on a release.

Regular expressions and basic character manipulation has been used to avoid the need for JSON parsing and Semver libraries.

Backport to 6.x on merge.

Mpdreamz
Mpdreamz approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brute force 😄 LGTM

@russcam russcam merged commit 85cdf95 into master Mar 5, 2019
russcam pushed a commit that referenced this pull request Mar 5, 2019
@russcam
Use the version number present in the global.json file when generatin…
3b9cde8 
…g documentation. (#3557)

(cherry picked from commit 85cdf95)
@russcam
Copy link
Contributor

russcam commented Mar 5, 2019

ported to 6.x: 3b9cde8
ported to 5.x: 4e08047

russcam pushed a commit that referenced this pull request Mar 5, 2019
@russcam
Use the version number present in the global.json file when generatin…
4e08047 
…g documentation. (#3557)

(cherry picked from commit 85cdf95)
@russcam russcam deleted the feature/use-global-json-in-docs branch March 28, 2019 02:52
russcam pushed a commit that referenced this pull request Apr 3, 2019
@russcam
Use the version number present in the global.json file when generatin…
0987576 
…g documentation. (#3557)

(cherry picked from commit 85cdf95)
(cherry picked from commit 3b9cde8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebrain @russcam @Mpdreamz