Skip to content

Reindex attachment honours ingest-attachment field names #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Mar 14, 2019

This commit updates the Attachment Json converter to use the
ingest-geoip attachment field names when serializing an attachment.

The current serialization implementation is based on mapper-attachments plugin which
was deprecated in 5.x and removed in 6.x.

Fixes #3502

This commit updates the Attachment Json converter to use the
ingest-geoip attachment field names when serializing an attachment.

The current serialization implementation is based on mapper-attachments plugin which
was deprecated in 5.x and removed in 6.x.

Fixes #3502
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit 1e4d7aa into 6.6 Mar 15, 2019
russcam added a commit that referenced this pull request Mar 20, 2019
This commit updates the Attachment Json converter to use the
ingest-geoip attachment field names when serializing an attachment.

The current serialization implementation is based on mapper-attachments plugin which
was deprecated in 5.x and removed in 6.x.

Fixes #3502
russcam added a commit that referenced this pull request Mar 21, 2019
This commit updates the Attachment Json converter to use the
ingest-geoip attachment field names when serializing an attachment.

The current serialization implementation is based on mapper-attachments plugin which
was deprecated in 5.x and removed in 6.x.

Fixes #3502
@russcam russcam deleted the fix/attachment-serialization branch March 27, 2019 03:40
russcam added a commit that referenced this pull request Apr 2, 2019
This commit updates the Attachment Json converter to use the
ingest-geoip attachment field names when serializing an attachment.

The current serialization implementation is based on mapper-attachments plugin which
was deprecated in 5.x and removed in 6.x.

Fixes #3502

(cherry picked from commit 5a78a43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants