Fix ActionIds type #3610
Merged
Fix ActionIds type #3610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
codebrain
commented
Mar 18, 2019
codebrain
commented
- Ensure GetHashcode() returns same value for out of order lists.
- Prefer empty lists over nulls for internal _actionIds collection.
…r empty lists over nulls for internal _actionIds collection.
russcam
suggested changes
Mar 18, 2019
russcam
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
LGTM. @codebrain could you check you're happy with the changes?
|
@russcam - Looks good! ++ to the test. |
russcam
pushed a commit
that referenced
this pull request
Mar 20, 2019
Ensure GetHashcode() returns same value for out of order lists.
russcam
pushed a commit
that referenced
this pull request
Mar 21, 2019
Ensure GetHashcode() returns same value for out of order lists.
russcam
pushed a commit
that referenced
this pull request
Apr 3, 2019
Ensure GetHashcode() returns same value for out of order lists. (cherry picked from commit c1a705a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.