Deserialize DateHistogram bucket with no sub aggregations #3678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebrain
approved these changes
Apr 29, 2019
| @@ -745,15 +757,21 @@ private IBucket GetDateHistogramBucket(ref JsonReader reader, IJsonFormatterReso | |||
| reader.ReadNext(); // , | |||
| reader.ReadNext(); // "key" | |||
| reader.ReadNext(); // : | |||
| var key = reader.ReadNullableLong().GetValueOrDefault(0); | |||
| var key = reader.ReadInt64(); | |||
There was a problem hiding this comment.
This is an artifact of porting over from Json.NET, where the conversion is made to long? - I don't believe nullability it's actually needed here, based on
| reader.ReadNext(); // , | ||
| reader.ReadNext(); // "doc_count" | ||
| reader.ReadNext(); // : | ||
| var docCount = reader.ReadNullableLong().GetValueOrDefault(0); | ||
| reader.ReadNext(); // , | ||
| var docCount = reader.ReadInt64(); |
There was a problem hiding this comment.
Again, no longer nullable?
There was a problem hiding this comment.
Similar to previous comment, this is an artifact of porting over from Json.NET. Based on
there is always a long value for doc count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3673