Skip to content

Remove _source_include and _source_exclude from generated #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2019
Merged

Remove _source_include and _source_exclude from generated #3726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/CodeGeneration/ApiGenerator/Overrides/GlobalOverrides.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ public class GlobalOverrides : EndpointOverridesBase
{ "_source", "source_enabled" },
{ "_source_includes", "source_include" },
{ "_source_excludes", "source_exclude" },
{ "_source_include", "source_include" },
{ "_source_exclude", "source_exclude" },
{ "rest_total_hits_as_int", "total_hits_as_integer" },
{ "docvalue_fields", "doc_value_fields" },
{ "q", "query_on_query_string" },
Expand All @@ -56,6 +54,7 @@ public class GlobalOverrides : EndpointOverridesBase
"source", // allows the body to be specified as a request param, we do not want to advertise this with a strongly typed method
"ttl",
"timestamp",
"_source_include", "_source_exclude" // can be removed once https://github.com/elastic/elasticsearch/pull/41439 is in
};
}
}
4 changes: 2 additions & 2 deletions src/Elasticsearch.Net/Domain/RequestParameters/RequestParameters.Generated.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,9 +855,9 @@ public class GetRequestParameters : RequestParameters<GetRequestParameters>
///<summary>True or false to return the _source field or not, or a list of fields to return</summary>
public bool? SourceEnabled { get => Q<bool?>("_source"); set => Q("_source", value); }
///<summary>A list of fields to exclude from the returned _source field</summary>
public string[] SourceExclude { get => Q<string[]>("_source_exclude"); set => Q("_source_exclude", value); }
public string[] SourceExclude { get => Q<string[]>("_source_excludes"); set => Q("_source_excludes", value); }
///<summary>A list of fields to extract and return from the _source field</summary>
public string[] SourceInclude { get => Q<string[]>("_source_include"); set => Q("_source_include", value); }
public string[] SourceInclude { get => Q<string[]>("_source_includes"); set => Q("_source_includes", value); }
///<summary>Explicit version number for concurrency control</summary>
public long? Version { get => Q<long?>("version"); set => Q("version", value); }
///<summary>Specific version type</summary>
Expand Down
8 changes: 4 additions & 4 deletions src/Nest/_Generated/_Descriptors.generated.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1471,14 +1471,14 @@ internal GetDescriptor() : base(){}
///<summary>Whether the _source should be included in the response.</summary>
public GetDescriptor<TDocument> SourceEnabled(bool? sourceEnabled = true) => Qs("_source", sourceEnabled);
///<summary>A list of fields to exclude from the returned _source field</summary>
public GetDescriptor<TDocument> SourceExclude(Fields sourceExclude) => Qs("_source_exclude", sourceExclude);
public GetDescriptor<TDocument> SourceExclude(Fields sourceExclude) => Qs("_source_excludes", sourceExclude);
///<summary>A list of fields to exclude from the returned _source field</summary>
public GetDescriptor<TDocument> SourceExclude(params Expression<Func<TDocument, object>>[] fields) => Qs("_source_exclude", fields?.Select(e=>(Field)e));
public GetDescriptor<TDocument> SourceExclude(params Expression<Func<TDocument, object>>[] fields) => Qs("_source_excludes", fields?.Select(e=>(Field)e));

///<summary>A list of fields to extract and return from the _source field</summary>
public GetDescriptor<TDocument> SourceInclude(Fields sourceInclude) => Qs("_source_include", sourceInclude);
public GetDescriptor<TDocument> SourceInclude(Fields sourceInclude) => Qs("_source_includes", sourceInclude);
///<summary>A list of fields to extract and return from the _source field</summary>
public GetDescriptor<TDocument> SourceInclude(params Expression<Func<TDocument, object>>[] fields) => Qs("_source_include", fields?.Select(e=>(Field)e));
public GetDescriptor<TDocument> SourceInclude(params Expression<Func<TDocument, object>>[] fields) => Qs("_source_includes", fields?.Select(e=>(Field)e));

///<summary>Explicit version number for concurrency control</summary>
public GetDescriptor<TDocument> Version(long? version) => Qs("version", version);
Expand Down
4 changes: 2 additions & 2 deletions src/Nest/_Generated/_Requests.generated.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3915,9 +3915,9 @@ internal GetRequest() : base(){}
///<summary>Whether the _source should be included in the response.</summary>
public bool? SourceEnabled { get => Q<bool?>("_source"); set => Q("_source", value); }
///<summary>A list of fields to exclude from the returned _source field</summary>
public Fields SourceExclude { get => Q<Fields>("_source_exclude"); set => Q("_source_exclude", value); }
public Fields SourceExclude { get => Q<Fields>("_source_excludes"); set => Q("_source_excludes", value); }
///<summary>A list of fields to extract and return from the _source field</summary>
public Fields SourceInclude { get => Q<Fields>("_source_include"); set => Q("_source_include", value); }
public Fields SourceInclude { get => Q<Fields>("_source_includes"); set => Q("_source_includes", value); }
///<summary>Explicit version number for concurrency control</summary>
public long? Version { get => Q<long?>("version"); set => Q("version", value); }
///<summary>Specific version type</summary>
Expand Down