Lazy document now uses source serializer and has async overloads #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This normalizes
LazyDocumenta bit and makes it flow through the source serializer rather than sidestepping it through a formatter (a path source serializer will also take).Also added
asyncoverloads toILazyDocument, since its currently backed abyte[]not immediately needed but good to have as part of the interface in7.xgoing forward.This also updates
RecyclableStreamFactoryto simply returnMemoryStream(bytes)rather then going through the hoops inRecyclableStream(bytes)which ends up doing a copy which seems unnecessary.