Skip to content

Make Should implementation explicit #3879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Make Should implementation explicit #3879

merged 1 commit into from
Jun 26, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 26, 2019

Relates: #3855

This PR makes the implementation of ShouldSerialize methods explicit on the BoolQuery implementations

@russcam russcam added the v7.0.0 label Jun 26, 2019
@russcam russcam requested review from codebrain and Mpdreamz June 26, 2019 07:09
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ don't need to be public facing

@Mpdreamz Mpdreamz merged commit 450fd73 into 7.x Jun 26, 2019
@Mpdreamz Mpdreamz deleted the fix/3855 branch June 26, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants