Skip to content

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Aug 2, 2019

This moves to a version of elasticsearch-net-abstraction that forcefully sets JAVA_HOME again as environment variable since this gets sets after System.Diagnostics.Process gets new'ed up.

The cluster bootstrap sets JAVA_HOME to the bundled jdk explicitly, this picks that up.

@Mpdreamz Mpdreamz marked this pull request as ready for review August 6, 2019 17:59
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mpdreamz Mpdreamz merged commit 3da50b6 into 7.x Aug 7, 2019
@Mpdreamz Mpdreamz deleted the fix/7.x/snapshot-test-bundled-jdk branch August 7, 2019 07:13
@Mpdreamz Mpdreamz added the Infra label Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants