Serialize GeoLocation with internal serializer #3997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds GeoLocation to types handled by the internal serializer so that a property on a document POCO of type GeoLocation is serialized by the internal serializer. It's not possible with the current test configuration to test this scenario, because IL rewriting happens after unit tests are run, so the Json.NET constructs used on Nest types are recognised by the JsonNetSerializer. Have added test that _would_ test behaviour, should tests be run after IL-merging in the future. Fixes #3981
|
Our |
Mpdreamz
approved these changes
Aug 7, 2019
Mpdreamz
pushed a commit
that referenced
this pull request
Aug 9, 2019
This commit adds GeoLocation to types handled by the internal serializer so that a property on a document POCO of type GeoLocation is serialized by the internal serializer. It's not possible with the current test configuration to test this scenario, because IL rewriting happens after unit tests are run, so the Json.NET constructs used on Nest types are recognised by the JsonNetSerializer. Have added test that _would_ test behaviour, should tests be run after IL-merging in the future. Fixes #3981 (cherry picked from commit 623c724)
Mpdreamz
pushed a commit
that referenced
this pull request
Aug 9, 2019
This commit adds GeoLocation to types handled by the internal serializer so that a property on a document POCO of type GeoLocation is serialized by the internal serializer. It's not possible with the current test configuration to test this scenario, because IL rewriting happens after unit tests are run, so the Json.NET constructs used on Nest types are recognised by the JsonNetSerializer. Have added test that _would_ test behaviour, should tests be run after IL-merging in the future. Fixes #3981 (cherry picked from commit 623c724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds GeoLocation to types handled by the internal serializer so that
a property on a document POCO of type GeoLocation is serialized by the internal serializer.
It's not possible with the current test configuration to test this scenario, because
IL rewriting happens after unit tests are run, so the Json.NET constructs used on Nest types
are recognised by the JsonNetSerializer. Have added test that would test behaviour, should
tests be run after IL-merging in the future.
Fixes #3981