Skip to content

make sure types that implement DebuggerDisplay override ToString sinc… #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2019
Merged

make sure types that implement DebuggerDisplay override ToString sinc… #4002

merged 1 commit into from
Aug 9, 2019

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Aug 7, 2019

…e these are likely to get logged

@Mpdreamz Mpdreamz mentioned this pull request Aug 7, 2019
Closed
codebrain
codebrain approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@Mpdreamz Mpdreamz merged commit c1b3845 into master Aug 9, 2019
@Mpdreamz Mpdreamz deleted the fix/master/to-string-infer-types branch August 9, 2019 10:06
Mpdreamz added a commit that referenced this pull request Aug 9, 2019
@Mpdreamz
make sure types that implement DebuggerDisplay override ToString sinc…
901e60d 
…e these are likely to get logged (#4002)

(cherry picked from commit c1b3845)
@russcam russcam added the v6.8.2 label Aug 15, 2019
russcam pushed a commit that referenced this pull request Aug 15, 2019
@Mpdreamz @russcam
make sure types that implement DebuggerDisplay override ToString sinc…
c30d4b5 
…e these are likely to get logged (#4002)

(cherry picked from commit 901e60d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@codebrain codebrain codebrain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mpdreamz @codebrain @russcam