Skip to content

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Aug 12, 2019

This commit adds additional XML docs to indicate that Index on BulkAllRequest<T> will be inferred from T. When a default index has not been mapped for
T on ConnectionSettings, using DefaultMappingFor<T>(m => m.IndexName("some_index")), an exception will be thrown.

Closes #3951

This commit adds additional XML docs to indicate that Index on BulkAllRequest<T> will be inferred from T. When a default index has not been mapped for
T on ConnectionSettings, using DefaultMappingFor<T>(m => m.IndexName("some_index")), an exception will be thrown.

Closes #3951
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

@russcam russcam merged commit 11d3ba3 into master Aug 13, 2019
russcam added a commit that referenced this pull request Aug 13, 2019
This commit adds additional XML docs to indicate that Index on BulkAllRequest<T> will be inferred from T. When a default index has not been mapped for
T on ConnectionSettings, using DefaultMappingFor<T>(m => m.IndexName("some_index")), an exception will be thrown.

Closes #3951

(cherry picked from commit 11d3ba3)
russcam added a commit that referenced this pull request Aug 13, 2019
This commit adds additional XML docs to indicate that Index on BulkAllRequest<T> will be inferred from T. When a default index has not been mapped for
T on ConnectionSettings, using DefaultMappingFor<T>(m => m.IndexName("some_index")), an exception will be thrown.

Closes #3951

(cherry picked from commit 11d3ba3)
@russcam
Copy link
Contributor Author

russcam commented Aug 13, 2019

ported to 6.x and 7.x

@russcam russcam deleted the docs/bulk-all-index branch August 13, 2019 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BulkAll requires DefaultIndex or DefaultMappingFor with index
2 participants