Map node failures. #4019
Merged
Map node failures. #4019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3851
russcam
approved these changes
Aug 13, 2019
That really means creating an integration test that creates a failure on the node and then asserts this is present. Whilst we could do this, I don't see that it provides much value over a unit test. The class maps this object: https://github.com/elastic/elasticsearch/blob/a086c665a35af32e60e6d23ab6ca75fcf085b46f/client/rest-high-level/src/main/java/org/elasticsearch/client/NodesResponseHeader.java#L55 I can look to add something to |
codebrain
added a commit
that referenced
this pull request
Aug 16, 2019
russcam
pushed a commit
that referenced
this pull request
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3851