Skip to content

Support StringTimeSpanAttribute #4052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Support StringTimeSpanAttribute #4052

merged 1 commit into from
Aug 30, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Aug 27, 2019

This commit supports StringTimeSpan attribute on TimeSpan and TimeSpan? properties.

It also brings in upstream PR to fix ISO8601TimeSpanFormatter deserialization: neuecc/Utf8Json#101

Fixes #3857

This commit supports StringTimeSpan attribute on TimeSpan and TimeSpan? properties.

It also brings in upstream PR to fix ISO8601TimeSpanFormatter deserialization: neuecc/Utf8Json#101

Fixes #3857
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit da9836e into master Aug 30, 2019
russcam added a commit that referenced this pull request Aug 30, 2019
This commit supports StringTimeSpan attribute on TimeSpan and TimeSpan? properties.

It also brings in upstream PR to fix ISO8601TimeSpanFormatter deserialization: neuecc/Utf8Json#101

Fixes #3857

(cherry picked from commit da9836e)
@russcam
Copy link
Contributor Author

russcam commented Aug 30, 2019

ported to 7.x

@russcam russcam deleted the fix/3857 branch September 1, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimespanToStringFormatterResolver implementation
2 participants