Skip to content

Serialize first precision value on GeoSuggest #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Serialize first precision value on GeoSuggest #4106

merged 1 commit into from
Sep 30, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Sep 29, 2019

Relates: #4091

This commit adds a SerializeAsSingleFormatter to serialize only the first value in the Precision collection
for a GeoSuggestContext context mapping for the "completion" field data type.

Move the Context mapping related types to the Nest/Mapping/Types/Specialized/Completion directory to disambiguate
from the context query types.

Deprecate the Neighbors property on IGeoSuggestContext.

Relates: #4091

This commit adds a SerializeAsSingleFormatter<T> to serialize only the first value in the Precision collection
for a GeoSuggestContext context mapping for the "completion" field data type.

Move the Context mapping related types to the Nest/Mapping/Types/Specialized/Completion directory to disambiguate
from the context query types.

Deprecate the Neighbors property on IGeoSuggestContext.
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit 96add21 into 7.x Sep 30, 2019
russcam added a commit that referenced this pull request Oct 1, 2019
Relates: #4091

This commit adds a SerializeAsSingleFormatter<T> to serialize only the first value in the Precision collection
for a GeoSuggestContext context mapping for the "completion" field data type.

Move the Context mapping related types to the Nest/Mapping/Types/Specialized/Completion directory to disambiguate
from the context query types.

Deprecate the Neighbors property on IGeoSuggestContext.
@Mpdreamz Mpdreamz deleted the fix/geosuggest branch November 6, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants