Fix Extended stats deserialization #4109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where datetime extended_stats aggregation was getting deserialized as a regular stats aggregation
Note that this fix might not impact anything in practice, since when this code is hit, the rest of the fields are "as_string" fields anyways (in the response examples I'm aware of).
…into benbenwilde-6.x
This commit adds a unit test to assert that the change to AggregateJsonConverter for ExtendedStats aggregation can deserialize the provided response.
russcam
added a commit
that referenced
this pull request
Sep 30, 2019
russcam
added a commit
that referenced
this pull request
Sep 30, 2019
russcam
added a commit
that referenced
this pull request
Oct 1, 2019
|
@russcam I'm still having issues with a datetime extended stats aggregation dropping subsequent aggregations. It looks like we need another I believe once the aggregate is parsed, the reader is supposed to end on the end token of the aggregation object. However, it looks like it's ending on the end token of the |
|
Thanks @benbenwilde, that does sound like the case if subsequent aggs are not parsed and returned in the search response instance . I'll take a look at it today |
russcam
added a commit
that referenced
this pull request
Oct 3, 2019
Relates: #4109 This commit fixes an issue with extended stats aggregation parsing whereby the closing brace of std_deviation_bounds_as_string is not read when skipping over the object, leading to the reader exiting at this point, resulting in any subsequent aggregations from not being read from the JSON response and added to SearchResponse.Aggregations.
|
@benbenwilde I've opened #4118 to address |
russcam
added a commit
that referenced
this pull request
Oct 8, 2019
Relates: #4109 This commit fixes an issue with extended stats aggregation parsing whereby the closing brace of std_deviation_bounds_as_string is not read when skipping over the object, leading to the reader exiting at this point, resulting in any subsequent aggregations from not being read from the JSON response and added to SearchResponse.Aggregations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #4103
Adds a unit test to assert that the change to
AggregateJsonConverterfor ExtendedStats aggregationcan deserialize the provided response.