Fix initial randomization of nodes #4112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the initial randomization of nodes in a StaticConnectionPool. Instead of calling the protected ctor, the initialization logic has been pulled out into a separate method that is now called from the ctor that accepts a randomize parameter. Fixes #4055
Mpdreamz
approved these changes
Sep 30, 2019
|
|
||
| // assertion works on the probability of seeing a Uri other than https://10.0.0.1:9200/ | ||
| // as the first value over 50 runs, when randomized. | ||
| Enumerable.Repeat(CreatStaticConnectionPool().CreateView().First().Uri.ToString(), 50) |
There was a problem hiding this comment.
I am looking to seeing this randomly fail 😸
russcam
added a commit
that referenced
this pull request
Oct 1, 2019
This commit fixes the initial randomization of nodes in a StaticConnectionPool. Instead of calling the protected ctor, the initialization logic has been pulled out into a separate method that is now called from the ctor that accepts a randomize parameter. Fixes #4055 (cherry picked from commit 02dfd4b)
|
ported to 6.x |
russcam
added a commit
that referenced
this pull request
Oct 1, 2019
This commit fixes the initial randomization of nodes in a StaticConnectionPool. Instead of calling the protected ctor, the initialization logic has been pulled out into a separate method that is now called from the ctor that accepts a randomize parameter. Fixes #4055
russcam
added a commit
that referenced
this pull request
Oct 1, 2019
This commit fixes the initial randomization of nodes in a StaticConnectionPool. Instead of calling the protected ctor, the initialization logic has been pulled out into a separate method that is now called from the ctor that accepts a randomize parameter. Fixes #4055
russcam
added a commit
that referenced
this pull request
Oct 3, 2019
This commit fixes the initial randomization of nodes in a StaticConnectionPool. Instead of calling the protected ctor, the initialization logic has been pulled out into a separate method that is now called from the ctor that accepts a randomize parameter. Fixes #4055
This was referenced Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the initial randomization of nodes in a StaticConnectionPool. Instead of calling the protected ctor,
the initialization logic has been pulled out into a separate method that is now called from the ctor that accepts a
randomize parameter.
Fixes #4055