Skip to content

Added fields block (docvalue_fields) to SuggestOption #4148 #4149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2019
Merged

Added fields block (docvalue_fields) to SuggestOption #4148 #4149

merged 1 commit into from
Oct 22, 2019

Conversation

Treno1
Copy link

@Treno1 Treno1 commented Oct 15, 2019

Copied from Hit.cs

@ghost
Copy link

ghost commented Oct 15, 2019

Hi @Treno1, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@Mpdreamz
Copy link
Member

HI @Treno1 this LGTM, mind signing the CLA with the email from the commit ?

@Treno1
Copy link
Author

Treno1 commented Oct 18, 2019

Signed, sorry for delay

@russcam russcam merged commit 45c4d60 into elastic:6.x Oct 22, 2019
@russcam
Copy link
Contributor

russcam commented Oct 22, 2019

Add docvalue_fields to SuggestUsage tests. Thanks for the PR, @Treno1 👍

@russcam
Copy link
Contributor

russcam commented Oct 22, 2019

ported to 7.x and master

@russcam russcam mentioned this pull request Oct 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Treno1 @Mpdreamz @russcam