Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add average_search_time_per_bucket_ms and total_bucket_processing_tim… #4163

Merged
merged 2 commits into from Oct 21, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Oct 21, 2019

…e_ms to ml stats

Relates: elastic/elasticsearch#44125

This commit adds DatafeedTimingStats to DatafeedStats, and ExponentialAverageBucketProcessingTimePerHourMilliseconds to
JobStats.

…e_ms to ml stats

Relates: elastic/elasticsearch#44125

This commit adds DatafeedTimingStats to DatafeedStats, and ExponentialAverageBucketProcessingTimePerHourMilliseconds to
JobStats.
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one failing integration test unrelated. Opened #4167 to adress it later.

@@ -40,7 +40,9 @@ protected override void ExpectResponse(GetDatafeedStatsResponse response)
{
response.ShouldBeValid();
response.Count.Should().BeGreaterOrEqualTo(1);
response.Datafeeds.First().State.Should().Be(DatafeedState.Stopped);
var datafeedStats = response.Datafeeds.First();
datafeedStats.State.Should().Be(DatafeedState.Stopped);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@russcam russcam merged commit 83bf3e3 into 7.x Oct 21, 2019
russcam added a commit that referenced this pull request Oct 21, 2019
…e_ms to ml stats (#4163)

Relates: elastic/elasticsearch#44125

This commit adds DatafeedTimingStats to DatafeedStats, and ExponentialAverageBucketProcessingTimePerHourMilliseconds to
JobStats.

(cherry picked from commit 83bf3e3)
@russcam
Copy link
Contributor Author

russcam commented Oct 21, 2019

ported to master

@Mpdreamz Mpdreamz deleted the feature/timing-stats-avg-search-time branch November 6, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants