Support MemberExpression and specific MethodCallExpression #4268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for MemberExpression and specific MethodCallExpression as Expressions that can be passed to Field and PropertyName, in order to resolve a string value from the expression. The specific MethodCallExpression support is to allow F# quotations enclosing Lambda expressions to be supported, when converted using Microsoft.FSharp.Linq.RuntimeHelpers.LeafExpressionConverter.QuotationToExpression Fixes #4240
Mpdreamz
reviewed
Dec 13, 2019
| type = memberExpression.Member.DeclaringType; | ||
| break; | ||
| case MethodCallExpression methodCallExpression: | ||
| // special case F# method call expressions on FuncConvert |
Mpdreamz
approved these changes
Dec 13, 2019
|
ported to master |
russcam
added a commit
that referenced
this pull request
Dec 16, 2019
This commit adds support for MemberExpression and specific MethodCallExpression as Expressions that can be passed to Field and PropertyName, in order to resolve a string value from the expression. The specific MethodCallExpression support is to allow F# quotations enclosing Lambda expressions to be supported, when converted using Microsoft.FSharp.Linq.RuntimeHelpers.LeafExpressionConverter.QuotationToExpression Fixes #4240 (cherry picked from commit 9949008)
niemyjski
reviewed
Dec 18, 2019
| @@ -56,6 +56,7 @@ public Field(PropertyInfo property, double? boost = null, string format = null) | |||
| /// </remarks> | |||
| public string Format { get; set; } | |||
|
|
|||
| // TODO: Rename to CacheableExpression in 8.0.0 | |||
There was a problem hiding this comment.
Why not introduce it now, put an obsolete attribute on this and have the getter and setter populate the new property?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for MemberExpression and specific MethodCallExpression
as Expressions that can be passed to Field and PropertyName, in order to resolve
a string value from the expression.
The specific MethodCallExpression support is to allow F# quotations enclosing
Lambda expressions to be supported, when converted using
Microsoft.FSharp.Linq.RuntimeHelpers.LeafExpressionConverter.QuotationToExpression
Fixes #4240