Implement _source parameter on action and doc lines. #4339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
suggested changes
Feb 3, 2020
|
@codebrain let me know when this is ready to review again |
Ready @russcam! |
russcam
suggested changes
Feb 7, 2020
russcam
suggested changes
Feb 7, 2020
src/Nest/Document/Multiple/Bulk/BulkResponseItem/BulkResponseItemBase.cs
Show resolved
Hide resolved
russcam
approved these changes
Feb 10, 2020
|
@codebrain have the Bulk Update supporting |
|
It has not been ported to |
russcam
pushed a commit
that referenced
this pull request
Feb 24, 2020
Implement _source parameter on action and doc lines. (cherry picked from commit e4c1d35)
russcam
pushed a commit
that referenced
this pull request
Feb 24, 2020
russcam
added a commit
that referenced
this pull request
Feb 24, 2020
Implement _source parameter on action and doc lines. (cherry picked from commit e4c1d35)
russcam
added a commit
that referenced
this pull request
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation (https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html) indicates that
_sourceis valid on both the action and the doc lines (see the JSON example at the bottom of the page).This PR is in draft whilst it is ratified if there is any precendence in parameters being set, or if the parameters are preferred on the action line or doc line.