Skip to content

DynamicValue can now dispatch into arrays #4351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2020

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Feb 3, 2020

e.g .Get<string[]>("dataframes.id") will work even if dataframes is a an array of objects. This makes picking values dynamically a ton easier.

(cherry picked from commit 1218888)

Isolated from #4336

e.g `.Get<string[]>("dataframes.id")` will work even if `dataframes` is a an array of objects. This makes picking values dynamically a ton easier.

(cherry picked from commit 1218888)
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some small comments

@Mpdreamz Mpdreamz merged commit c0d6e62 into master Feb 4, 2020
Mpdreamz added a commit that referenced this pull request Feb 4, 2020
* DynamicValue can now dispatch into arrays

e.g `.Get<string[]>("dataframes.id")` will work even if `dataframes` is a an array of objects. This makes picking values dynamically a ton easier.

(cherry picked from commit 1218888)

* update docs

* address PR feedback

* fix unit test

* update docs

(cherry picked from commit c0d6e62)
@Mpdreamz Mpdreamz deleted the feature/master/dynamic-dictionary-projections branch February 4, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants